search

florath / rmtoo

Free and Open Source Requirements Management TooL
http://rmtoo.florath.net
Other
207 stars 59 forks source link

Rflo/master #39

Open kown7 opened 4 years ago

kown7 commented 4 years ago
codecov-commenter commented 4 years ago

Codecov Report

Merging #39 into master will increase coverage by 0.14%. The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   90.81%   90.95%   +0.14%     
==========================================
  Files         110      110              
  Lines        4703     4799      +96     
==========================================
+ Hits         4271     4365      +94     
- Misses        432      434       +2
Impacted Files Coverage Δ
src/rmtoo/inputs/RDepConstraints.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepDependsOn.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepMasterNodes.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepNoDirectedCircles.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepOneComponent.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepPriority.py 100.00% <ø> (ø)
src/rmtoo/inputs/RDepSolvedBy.py 100.00% <ø> (ø)
src/rmtoo/inputs/ReqCE3.py 100.00% <ø> (ø)
src/rmtoo/inputs/ReqClass.py 100.00% <ø> (ø)
src/rmtoo/inputs/ReqConstraints.py 100.00% <ø> (ø)
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 633c470...8ef7ff6. Read the comment docs.

florath commented 4 years ago

Hello! Thanks for providing the changes / pull request. I'm sorry, but I'm not able to merge this: it is just too big. A pull / merge request should implement one feature / problem. What I see here is that many different aspects are merged into one request: some of them I'll not accept (or at least we should discuss them first). Example: you remove files which I (still) need. Please split up the changes feature-wise and provide appropriate pull requests.

kown7 commented 4 years ago

It's basically just one feature: automated build/deploy using flit. I hardly see a point in splitting these commits. A git merge --squash isn't an option as it would break the tests again.