Closed clarfonthey closed 5 years ago
Maybe we shouldn't create a giant mess, but actually take the time to do it "right"? That's kind of what we want to do, take it easy, not rush and push to get stuff out.
I realize we do want to do it because of the bots and stuff, I get that, but I really don't think it's worth adding messy stuff that we need to clean up later, I rather just have the conversation with folk on pleroma and glitch BEFORE we add this in.
I will not approve this PR before we double check with them.
Gonna close this issue, think about this more, and open a new one once I've come up with a better solution.
Hello! Could you just append a "+florence" to the version (like glitch soc and semver specitfication does), at least? fediverse.network will detect you properly and I intend to display forks repartition & forks info on the Mastodon server page very soon.
RIght now the "forks" repartition is low on mastodon and improving this would be nice:
fd=# select count(id),semver->'build' from instances where server=2 group by server,semver->'build' order by count desc;
count | ?column?
-------+----------------------------------------
2579 |
2478 | []
78 | ["glitch"]
2 | ["g5b20284", "with", "comm-cx"]
2 | ["glitch", "sleeping"]
1 | ["glitch-0629-98c2d2a"]
1 | ["glitch", "vulpine-prod-20190622-01"]
1 | ["kazvam"]
1 | ["homu"]
1 | ["beachcity1", "8", "0"]
(10 rows)
Yeah, I posted in the other issue with thoughts on how to make this work. I would like to offer a Florence version string too because one of the benefits we offer is stable releases.
Not yet tested, but essentially, this would add two additional fields to the API:
flavor_name
, which we'll set toflorence
, andflavor_version
, which will be set to the actual version of Florence Mastodon. We should double-check with Pleroma and glitch-social before merging to co-ordinate with them and figure out if they're doing this through their own APIs, and/or if we want to make this official for app developers to take advantage of.The
Mastodon::Version::Equiv
object will contain an object closer to the actual Mastodon version, while the actualMastodon::Version
object will contain the Florence Mastodon version.This is a giant mess, but it solves the problem right now. Eventually, we'll want to extract all of the actual version information out of this file, and leave only Mastodon-equivalent stuff for the API here.