search

florence-social / mastodon-fork

Florence's fork of Mastodon
GNU Affero General Public License v3.0
138 stars 15 forks source link

Adding user option to disable blurhash #118

Open IsabelaY opened 5 years ago

IsabelaY commented 5 years ago

I've added an option for users to disable the blurhash and instead show a solid dark color in its place. This solves the issue #78.

clarfonthey commented 5 years ago

I like this change and am on board assuming that we can get someone else to vouch for the translations.

Longer term I think it'd be best to replace the disable-blurhash option with an enable-blurhash option, although we can do this with a migration in the future.

StarryAster commented 5 years ago

I like this change and am on board assuming that we can get someone else to vouch for the translations.

Longer term I think it'd be best to replace the disable-blurhash option with an enable-blurhash option, although we can do this with a migration in the future.

Regarding the existing translations, I can say the pt-BR one is as good as it gets, since "blurhash" isn't really a translatable word. I guess that could be reworded as "Desabilitar blurhash (borrão) para mídia escondida" ["Disable blurhash (blur) for hidden media"] or the whole string could be changed to be more specific (such as "use solid color instead of a blurhashed/blurred preview for hidden media", which in pt-BR would be "usar cor sólida ao invés de previsão borrada para mídia escondida"), but that doesn't really have anything to do with the translation.

I think people who speak European Portuguese can understand what the Brazilian translation is saying, but it would probably be better if someone familiar with European Portuguese could review that. (Both OP and I are Brazilian.)

Other translations should probably be added too, but I guess that would come later.

clarfonthey commented 5 years ago

Okay so, initially I was a bit confused because I thought that the PR was adding pt/es translations and was confused why they were both the same, and then I only just realised that these were pt/pt-BR translations.

I think that having European Portuguese speaker review would be good, if possible. Otherwise, we can just treat this as a missing translation for pt-PT.

clarfonthey commented 5 years ago

Also in terms of whether blurhash should be translated-- honestly, it makes sense to not even call it blurhash in English, as this is too technical of a term. Maybe instead of this, we could make this setting be a radio button: 1. Blur hidden media 2. Display hidden media as solid black

StarryAster commented 5 years ago

Solid color is a better guess than solid black; this PR changes the blurhash into "darken($ui-base-color, 6%)".

(This is mainly because it was originally made for an instance with several different themes.)

clarfonthey commented 5 years ago

Perhaps "solid, static colour" might be best? I'm mostly just trying to think of this to clarify that the colour doesn't change, because with black it obviously won't change, whereas solid colour could be a different colour per image.

ryliejamesthomas commented 5 years ago

Yeah, actually just popped-in to say what it looks like fon's already said: that blurhash isn't really a good term in English either. I wouldn't know what it meant but I coincidentally ended up on the blurhash github the other day~

This seems clearest to me (as radio buttons like mentioned)

Display hidden media as:

Solid implies one single colour.

clarfonthey commented 5 years ago

Do you think you'll be able to make some of these changes? I can pick it up if you don't have the time.

clarfonthey commented 5 years ago

@QueerNeko Thank you so much for the changes! Sorry you couldn't comment on the repo after it was silenced, but you should be able to comment now.

This will get merged some point after we release 0.1.1 so that it can get into 0.2.0.

IsabelaY commented 5 years ago

Alright, thanks! I recently realized that Mastodon also added this feature on their main branch:

https://github.com/tootsuite/mastodon/commit/3086c645fde2345d34e401bdf3e2f19f19da3294

clarfonthey commented 5 years ago

Thanks for pointing this out! I'll take a look later and see how best we should merge this.