florence-social / mastodon-fork

Florence's fork of Mastodon
GNU Affero General Public License v3.0
138 stars 15 forks source link

Keep random delay of media card generation from moving user buttons #152

Open kmosiejczuk opened 5 years ago

kmosiejczuk commented 5 years ago

Often on bsd.network, I will favorite a toot, go to boost or reply to the toot, and then end up clicking on the media card that just popped under my cursor as I clicked.

I have heard the explanation that the delay is because of a random delay inserted into the fetch so the fediverse doesn't DoS the website mentioned. OK.

I'd recommend that either:

Save room for the card to appear so it doesn't move the user buttons.

or

Don't display the toot until the card is generated.

I suppose another alternative would be not to refresh the toot while the mouse buttons is hovering over it.

clarfonthey commented 5 years ago

Alternatively we could show a placeholder the same size until the card is loaded. Although honestly, I don't know why this logic is in the client instead of on the server.