Implements GH issue #114 Allow for linking to line numbers in HTML output

florence / cover

a code coverage tool for racket

MIT License

38 stars 7 forks source link

Implements GH issue #114 Allow for linking to line numbers in HTML output #117

Closed SuzanneSoy closed 8 years ago

SuzanneSoy commented 8 years ago

The line given in the anchor has a grey brackground. It's done just using CSS, so:

If we remember the sort order by changing the anchor will need to also color the line, since the :target selector won't work anymore
Due to the way line numbers are made (a column div with all line numbers inside, and another div with all line text inside), just the line text is colored, not the line number.

florence commented 8 years ago

GH somehow counted 7aae005 in your commit, even though thats actually commit 3b5aa3acfa108af1fbccd0824c8de3dd78b42893... Any clue why thats happening? (its giving me wonky conflicts on the merge...)

SuzanneSoy commented 8 years ago

@florence Sorry about that, I might have accidentally run git commit --amend while being on the wrong commit, or something like that. Should be fixed, now.

florence commented 8 years ago

Merged, thanks!