search

florence / cover

a code coverage tool for racket
MIT License
38 stars 7 forks source link

Fixes GH issue #118 "Division by zero when there are no relevant expressions #119

Closed SuzanneSoy closed 8 years ago

SuzanneSoy commented 8 years ago

Fixed by showing 100% coverage in that case (100% is what coveralls.io shows when there are no relevant lines).

SuzanneSoy commented 8 years ago

I don't think the error with the HEAD version of racket is due to this PR, since it also occurs on the latest, unmodified master commit: https://travis-ci.org/jsmaniac/cover/builds/118027669

florence commented 8 years ago

Yes, that error is caused by a bug in the codecov API (exposed by some change to the contract system), which I've fixed: https://github.com/codecov/codecov-racket/commit/e20070da30562985bc7affdab8e8f7d7723417b9

How difficult would it be to add a few tests for this?

SuzanneSoy commented 8 years ago

@florence I added some tests for all three changes.

Also, there was a missing close paren on line 194 https://github.com/florence/cover/blob/master/cover/private/html/html.rkt#L194, which seemed to be closed later than it should, I fixed that too.

florence commented 8 years ago

Thanks!