florence / cover

a code coverage tool for racket
MIT License
38 stars 7 forks source link

Cover reveals hidden lines in ISL files #145

Closed florence closed 4 years ago

florence commented 4 years ago

The core issue here is that ISL has these sneak hidden lines at the top of the file that drracket knows to hide, but cover knows to ignore these lines. but, when all lines are ignored cover behaves oddly, assuming that every character is passed the end of the file.

florence commented 4 years ago

@tov once CI passes I'll merge this into the release. It should be out by tomorrow evening; if you have your students update things should work better!

tov commented 4 years ago

Thanks! It's actually happening on GitHub Actions, which means I install it fresh each time, so I should get it as soon as it’s on master.

J

On Mon, Oct 14, 2019 at 4:14 PM Spencer Florence notifications@github.com wrote:

Closed #145 https://github.com/florence/cover/issues/145.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/florence/cover/issues/145?email_source=notifications&email_token=AAFS3BDPCQNTYLSQDVC75KDQOTOJVA5CNFSM4JATNTEKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUGRV5PQ#event-2711838398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFS3BGQ4B5D4RJNQLFG5PDQOTOJVANCNFSM4JATNTEA .