check for nonexistent package

[jbclements]

Better error message on nonexistent package.

BTW, Behavior on nonexistent collections is even weirder... it just generates a report (100% coverage!) for zero files. Strange.

[codecov-io]

Codecov Report

Merging #146 into master will decrease coverage by 0.17%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   95.22%   95.04%   -0.18%     
==========================================
  Files          11       11              
  Lines        1067     1070       +3     
==========================================
+ Hits         1016     1017       +1     
- Misses         51       53       +2

Impacted Files	Coverage Δ
cover/raco.rkt	89.54% <33.33%> (-1.13%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c12684...d190f72. Read the comment docs.

[florence]

Thanks!

I suspect the missing collections issue is because it's not checking if collection-paths gives an empty result, and its there is a case in the html-renderer to give 100% code coverage to avoid a divide by zero error.

[jbclements]

Oh! Of course, I remember seeing that call to “flatten”, that would have exactly that effect.

BTW, apologies for lowering your coverage count, I considered refactoring to make that testable, but didn’t.

John

On Dec 9, 2019, at 1:02 PM, Spencer Florence notifications@github.com wrote:

Thanks!

I suspect the missing collections issue is because it's not checking if collection-paths gives an empty result, and its there is a case in the html-renderer to give 100% code coverage to avoid a divide by zero error.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[florence]

Oh no worries, that file is a mess and it's all my fault :P