florensie / artifacts-fabric

A Minecraft mod that adds various powerful items which can be found through exploration
https://www.curseforge.com/minecraft/mc-mods/artifacts-fabric
GNU Lesser General Public License v3.0
10 stars 10 forks source link

Custom Trinket Attributes Are Nullified #65

Open RobertHDPotatoes opened 2 years ago

RobertHDPotatoes commented 2 years ago

Describe the bug Using the /give command, you can give yourself trinkets with custom attributes. For example, doing

/give @p artifacts:bunny_hoppers{TrinketAttributeModifiers:[{Slot:"feet/shoes", AttributeName:"minecraft:generic.attack_damage", Name:"minecraft:generic.attack_damage", Amount:100.0, Operation:0, UUID:[I; 42853, 1689024593, -201178, -1559272105]}]}

you should get Bunny Hoppers with +100 attack damage. However, you do not, as these attributes seem to be nullified. Doing this with other mods that add trinkets to the game, it clearly works and even displays in the tooltip, "When equipped, +100 Attack Damage". This seems to be the case for all Artifacts trinkets, and only Artifacts trinkets as other mods are not affected.

To Reproduce Steps to reproduce the behavior:

  1. Install Trinkets & Artifacts
  2. Use the give command listed above
  3. Equip the bunny hoppers, attack something, you have no additional attack damage
  4. You could also install another mod that adds trinkets and try giving trinkets from other mods attributes, to see that it does work using that command and it should work like that.

Game Environment Please provide details about the game environment, either by crash report/logs or by detailing it below.

florensie commented 2 years ago

Does it work for artifacts without attribute modifiers by default? Try something simple like the whoopee cushion.

RobertHDPotatoes commented 2 years ago

Sorry for the late response, but no, unfortunately any/all custom trinket attributes don't seem to work. I've tried it on the Snorkel, Flame Pendant, Antidote Vessel, Cloud in a Bottle, Whoopee Cushion, Flame Gauntlet, Bunny Hoppers (plus a few others), and the attributes work on none of them, whereas with other trinkets mods it works just fine

RobertHDPotatoes commented 2 years ago

This issue seems to have come back in 1.19.2 (Or I may have never confirmed it was fixed in the first place? Not sure)

Minecraft Version: 1.19.2 Fabric API: 0.62.0 Artifacts: 7.1.1 Trinkets: 3.4.0

florensie commented 2 years ago

I'll reopen it and check later. I'm pretty sure it was actually fixed before.