florent37 / MaterialViewPager

A Material Design ViewPager easy to use library
https://www.fiches-plateau-moto.fr
Apache License 2.0
8.13k stars 1.48k forks source link

parallax problem #17

Closed MedoElkamaly closed 9 years ago

MedoElkamaly commented 9 years ago

parallax is not working right when using a lower dpi device (mdpi) g

bluebirdzx commented 9 years ago

1280*720 is same problem,but sample-debug.apk is ok

florent37 commented 9 years ago

can you check on the version 1.0.3.1 please

bluebirdzx commented 9 years ago

hi,1.0.3.1 is same problem screenshot_2015-05-11-13-33-15

florent37 commented 9 years ago

Dont know where this happens... Any idea ?

GHEEV commented 9 years ago

I saw the issue yesterday, testing a new version of my app with new version of your library. The version 1.0.0 didn't happened this issue... something you changed in the code...

MedoElkamaly commented 9 years ago

Did you tested it on mdpi device?

GHEEV commented 9 years ago

Oh sorry, no... It's a xdpi device.

Em qui, 14 de mai de 2015 03:14, MedoElkamaly notifications@github.com escreveu:

Did you tested it on mdpi device?

— Reply to this email directly or view it on GitHub.

GHEEV commented 9 years ago

I was changing somethings on my application, when I tried to implement "navigation bar color" and "navigation translucent" in styles-v21 and after that, the cards overlapped the tabs strips.. I'm thinking about that, and MAYBE, the problem is about the smartphones which there is fullscreen, like the both examples here and my application now (because the navigation bar is transparent, using all screen to show the content), make sense no?

MedoElkamaly commented 9 years ago

I didn't change any thing on the app, all I have done is run the same app on different device. On the xhdpi device the parallax work perfectly (still there is some issue with the title), and on the mdpi device the cards overlapped the tabs strips (like the example)

bluebirdzx commented 9 years ago

sample_debug.apk 1.04 is ok but my ower builder 1.04 is bad, maybe is other library cause

bluebirdzx commented 9 years ago

can you give me other libs source code? thanks of lot

florent37 commented 9 years ago

I used https://github.com/ksoichiro/Android-ObservableScrollView for the scroll listening. I don't understand why your own 1.0.4 would be different with sample_debug.apk 1.04. Can you try with emulators & send me a configuration which always fails please ?

(and thanks for your reports :+1:, helps me improving this lib )

Tibolte commented 9 years ago

Could this be resolved with the Design Support Library? CollapsingToolbarLayout looks like an alternative to ObservableScrollView. Support from 2.1 :)

florent37 commented 9 years ago

can you try with the "1.0.4.3" please ?

florent37 commented 9 years ago

@Tibolte it's not the same purpose, CollapsingToolbarLayout isn't an alternative, it works with CoordinatorLayout, I tried to implement it for recreate materialviewpager, but no succeed...

florent37 commented 9 years ago

try with the 1.0.5