search

florent37 / ShapeOfView

Give a custom shape to any android view, Material Design 2 ready
Apache License 2.0
3.12k stars 400 forks source link

Scrolling feature needed in fragments #1

Closed knightcube closed 6 years ago

knightcube commented 6 years ago

In some phones, the views cannot be seen properly. Putting things inside a ScrollView would help.

florent37 commented 6 years ago

oh, just for the sample...

knightcube commented 6 years ago

So can i work on the sample codebase?

florent37 commented 6 years ago

i added a scrollview on the sample

knightcube commented 6 years ago

can i work on some other issue sir?

florent37 commented 6 years ago

you can add others issues if you want

knightcube commented 6 years ago

I was actually looking for such a library for pretty long and now since you have come up with it i wanted to contribute in some way. I just wanted to know should i focus on the sample app or on making new shapes?

florent37 commented 6 years ago

You Can try to create some useful shapes

Le 23 févr. 2018 17:12, "Rajat Kumar Gupta" notifications@github.com a écrit :

I was actually looking for such a library for pretty long and now since you have come up with it i wanted to contribute in some way. I just wanted to know should i focus on the sample app or on making new shapes?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/florent37/ShapeOfView/issues/1#issuecomment-368055290, or mute the thread https://github.com/notifications/unsubscribe-auth/AFfQXJ1LnW_XQiKpH4HT-HfdHvCsxl6qks5tXuNbgaJpZM4SRFf2 .

knightcube commented 6 years ago

Okay i will try to do so