florent37 / ShapeOfView

Give a custom shape to any android view, Material Design 2 ready
Apache License 2.0
3.12k stars 400 forks source link

RoundRectView There is a problem with the rounded corners #12

Closed songlongkuan closed 6 years ago

songlongkuan commented 6 years ago

RoundRectView: screenshot_20180425-114857 XmlRadius: screenshot_20180425-114738 It seems that RoundRectView does not support full circle angle.

//RoundRectView info <com.github.florent37.shapeofview.shapes.RoundRectView android:layout_width="92dp" android:layout_height="28dp" android:layout_centerHorizontal="true" android:layout_centerVertical="true" ro:shape_roundRect_bottomLeftRadius="14dp" ro:shape_roundRect_bottomRightRadius="14dp" ro:shape_roundRect_topLeftRadius="14dp" ro:shape_roundRect_topRightRadius="14dp">

//Shape Xml info qq 20180425115741

florent37 commented 6 years ago

I see, I think it's because I do not use arc but another method, i'll try to fix it

Le mer. 25 avr. 2018 à 05:56, pencilso notifications@github.com a écrit :

//RoundRectView info <com.github.florent37.shapeofview.shapes.RoundRectView android:layout_width="92dp" android:layout_height="28dp" android:layout_centerHorizontal="true" android:layout_centerVertical="true" ro:shape_roundRect_bottomLeftRadius="14dp" ro:shape_roundRect_bottomRightRadius="14dp" ro:shape_roundRect_topLeftRadius="14dp" ro:shape_roundRect_topRightRadius="14dp">

//Shape Xml info

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/florent37/ShapeOfView/issues/12#issuecomment-384153506, or mute the thread https://github.com/notifications/unsubscribe-auth/AFfQXBVI46uBCflNAUW7G4fFTwUAOa3cks5tr_P7gaJpZM4TivrN .

florent37 commented 6 years ago

can you try the 1.0.8 ? I used arcTo instead of quadTo

songlongkuan commented 6 years ago

No way qq 20180518144258 left is RoundRectView right is shapeXml

florent37 commented 6 years ago

i fixed it in 1.0.9, check the result :

capture d ecran 2018-05-22 a 18 25 29
florent37 commented 6 years ago

can you try again ?

songlongkuan commented 6 years ago

good