search

florent37 / ShapeOfView

Give a custom shape to any android view, Material Design 2 ready
Apache License 2.0
3.12k stars 400 forks source link

Updating mask if it is different size than canvas #15

Closed DrRey closed 6 years ago

DrRey commented 6 years ago

When animating the view bounds (i.e. for shared transition) we need to update the mask as the bounds are changing.

florent37 commented 6 years ago

thanks, I wanted to implement it :)

do you think this could fix animations ?

DrRey commented 6 years ago

It did in my case. I was doing a FragmentTransaction with ShapeOfView as the shared element, and this is the only way I could make it work. Probably has a performance impact, but it wasn't noticable for me.

вт, 22 мая 2018 г., 18:24 Florent CHAMPIGNY notifications@github.com:

thanks, I wanted to implement it :)

do you think this could fix animations ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/florent37/ShapeOfView/pull/15#issuecomment-391032728, or mute the thread https://github.com/notifications/unsubscribe-auth/AHF6xpRRgYsQEYNZ6pjHh3gXt9abvM7Yks5t1C2bgaJpZM4UI0xF .