search

florent37 / ShapeOfView

Give a custom shape to any android view, Material Design 2 ready
Apache License 2.0
3.12k stars 400 forks source link

mask can be seen on android 4.4.2 #16

Closed martipello closed 6 years ago

martipello commented 6 years ago

using the arc i get a black mask showing on the left and right (where the arc is) of the view this is only showing up on android 4.4.2 have tried changing the order of the views inside and outside the view group to no avail

florent37 commented 6 years ago

can you send an image ?

martipello commented 6 years ago

here https://drive.google.com/file/d/1S1pZQoPrnGlgCc3YEg7MXVIv1u4yJyVl/view?usp=sharing and the xml 

<?xml version="1.0" encoding="utf-8"?>
<android.support.design.widget.CoordinatorLayout 
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:fancy="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent">

<android.support.constraint.ConstraintLayout
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <ImageView
        android:id="@+id/backgroundImageView"
        android:layout_width="0dp"
        android:layout_height="0dp"
        android:scaleType="centerCrop"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent" />

<android.support.v4.widget.NestedScrollView
    android:layout_width="0dp"
    android:layout_height="wrap_content"
    android:id="@+id/nested_scroll"
    app:layout_constraintEnd_toEndOf="parent"
    app:layout_constraintStart_toStartOf="parent"
    app:layout_constraintTop_toTopOf="parent">

    <android.support.constraint.ConstraintLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content">

        <com.github.florent37.shapeofview.shapes.ArcView
            android:id="@+id/shape_of_view"
            android:layout_width="0dp"
            android:layout_height="wrap_content"
            android:background="@color/colorPrimaryLight"
            android:elevation="4dp"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toTopOf="parent"
            app:shape_arc_cropDirection="outside"
            app:shape_arc_height="28dp"
            app:shape_arc_position="bottom">

            <android.support.constraint.ConstraintLayout
                android:layout_width="match_parent"
                android:layout_height="wrap_content">

                <net.grobas.view.MovingImageView
                    android:layout_width="0dp"
                    android:layout_height="0dp"
                    android:src="@drawable/mail_pattern"
                    app:layout_constraintBottom_toBottomOf="parent"
                    app:layout_constraintEnd_toEndOf="parent"
                    app:layout_constraintStart_toStartOf="parent"
                    app:layout_constraintTop_toTopOf="parent"
                    app:miv_load_on_create="true"
                    app:miv_max_relative_size="3"
                    app:miv_min_relative_offset="0.2"
                    app:miv_repetitions="-1"
                    app:miv_speed="100"
                    app:miv_start_delay="1000" />

                <TextView
                    android:id="@+id/profile_text"
                    android:layout_width="match_parent"
                    android:layout_height="wrap_content"
                    android:layout_margin="@dimen/fab_margin"
                    android:text="Your Profile"
                    android:textColor="@color/white"
                    android:textSize="16sp"
                    app:layout_constraintEnd_toEndOf="parent"
                    app:layout_constraintStart_toStartOf="parent"
                    app:layout_constraintTop_toTopOf="parent" />

                <de.hdodenhof.circleimageview.CircleImageView xmlns:app="http://schemas.android.com/apk/res-auto"
                    android:id="@+id/icon"
                    android:layout_width="146dp"
                    android:layout_height="146dp"
                    android:layout_marginBottom="@dimen/fab_margin"
                    android:src="@drawable/contact_placeholder"
                    app:civ_border_color="#FFFFFF"
                    app:civ_border_width="2dp"
                    app:layout_constraintBottom_toBottomOf="parent"
                    app:layout_constraintEnd_toEndOf="parent"
                    app:layout_constraintStart_toStartOf="parent"
                    app:layout_constraintTop_toBottomOf="@id/profile_text" />

                <ImageView
                    android:id="@+id/camera_icon"
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:layout_margin="@dimen/fab_margin"
                    android:src="@drawable/ic_photo_camera_black_24dp"
                    android:tag="default"
                    android:tint="@color/white"
                    app:layout_constraintBottom_toBottomOf="@id/icon"
                    app:layout_constraintStart_toStartOf="@id/icon" />

            </android.support.constraint.ConstraintLayout>
            <!-- YOUR CONTENT -->

        </com.github.florent37.shapeofview.shapes.ArcView>

        <android.support.design.widget.TextInputLayout
            android:id="@+id/phone_number_container"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:paddingLeft="16dp"
            android:paddingRight="16dp"
            android:paddingTop="@dimen/custom_margin"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toBottomOf="@id/shape_of_view">

            <EditText
                android:id="@+id/field_phone_number"
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:hint="Profile Name"
                android:inputType="textPersonName" />

        </android.support.design.widget.TextInputLayout>

        <android.support.design.widget.TextInputLayout
            android:id="@+id/status_container"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:paddingLeft="16dp"
            android:paddingRight="16dp"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toBottomOf="@id/phone_number_container">

            <EditText
                android:id="@+id/status_text"
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:hint="Profile Status"
                android:inputType="textPersonName" />

        </android.support.design.widget.TextInputLayout>

        <com.rilixtech.materialfancybutton.MaterialFancyButton
            android:id="@+id/button_start_verification"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_gravity="center"
            android:layout_marginEnd="@dimen/fab_margin"
            android:layout_marginStart="@dimen/fab_margin"
            android:layout_marginTop="20dp"
            android:paddingBottom="10dp"
            android:paddingLeft="20dp"
            android:paddingRight="20dp"
            android:paddingTop="10dp"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toBottomOf="@+id/status_container"
            fancy:mfb_borderColor="@color/colorAccent"
            fancy:mfb_borderWidth="1dp"
            fancy:mfb_defaultColor="@color/colorAccent"
            fancy:mfb_focusColor="#7ab800"
            fancy:mfb_radius="30dp"
            fancy:mfb_text="Save Changes"
            fancy:mfb_textColor="#FFFFFF" />

    </android.support.constraint.ConstraintLayout>

</android.support.v4.widget.NestedScrollView>

<android.support.v7.widget.RecyclerView
    android:layout_width="0dp"
    android:layout_height="wrap_content"
    android:id="@+id/status_recycler"
    android:layout_marginTop="@dimen/fab_margin"
    app:layout_constraintEnd_toEndOf="parent"
    app:layout_constraintStart_toStartOf="parent"
    app:layout_constraintTop_toBottomOf="@+id/nested_scroll">

</android.support.v7.widget.RecyclerView>

</android.support.constraint.ConstraintLayout>

</android.support.design.widget.CoordinatorLayout>

florent37 commented 6 years ago

remove the android:background="@color/colorPrimaryLight"

florent37 commented 6 years ago 
        remove the background of the ArcView
florent37 commented 6 years ago

and add it in the coordinator layout (child of the arcview)

martipello commented 6 years ago

OBVIOUSLY!!! What a stupid thing to do, sorry to have wasted your time (I knew it would be my problem not your libraries) many thanks

florent37 commented 6 years ago

Thanks you for using my lib :)

Le mer. 23 mai 2018 à 17:21, martipello notifications@github.com a écrit :

OBVIOUSLY!!! What a stupid thing to do, sorry to have wasted your time (I knew it would be my problem not your libraries) many thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/florent37/ShapeOfView/issues/16#issuecomment-391387811, or mute the thread https://github.com/notifications/unsubscribe-auth/AFfQXLNNkifBQXiRga40rMz9ahTJ7WNMks5t1X6FgaJpZM4UKmxV .

florent37 commented 6 years ago

I can override the setBackground to disable it

martipello commented 6 years ago

I wouldn't bother this comment will be here for anyone who runs into the issue it's working perfectly now, thanks for your awesome library