florent37 / SingleDateAndTimePicker

You can now select a date and a time with only one widget !
Apache License 2.0
1.02k stars 333 forks source link

Handling of leap dates. #250

Closed zsoltlengyelit closed 4 years ago

zsoltlengyelit commented 4 years ago

WheelDayPicker stores the exact Date of the labels so formatter is not forced to guess the year (wrongly)

Yennefer commented 4 years ago

@florent37 Will this changes be merged? I have the same problem when choosing February 29th in the picker

markspit93 commented 4 years ago

Thanks a lot for trying to fix this annoying bug. Are you aware that the sample app crashes on startup? I am having trouble making it work even after fixing the first error.

florent37 commented 4 years ago

thanks I merge it

Tgo1014 commented 4 years ago

I'm having the same issue, selecting Feb, 29 makes it return March, 1st.

greensopinion commented 4 years ago

I can see you changes, but there's a bug in it. When selecting 29-2-2020 (it's a leap date) it converts it into March 1st, when you select the leap date. Can you have a look?

See issue #254