search

florent37 / SingleDateAndTimePicker

You can now select a date and a time with only one widget !
Apache License 2.0
1.02k stars 333 forks source link

Update WheelDayPicker.java #255

Closed ondeweb closed 4 years ago

ondeweb commented 4 years ago

This issue arises due to the string date format to a Date object. Now we need to add string date with year format.

arberg commented 4 years ago

I've been going over the change-requests, and to this project. I don't see what it is you are trying to do with this change. Leap year works fine, as java calendar handles it, when we do stuff like

todayCalendar.add(Calendar.DAY_OF_YEAR,(itemPosition - todayPosition));

Also if there was a bug with that, we shouldn't fix it by going via texts.

G00fY2 commented 4 years ago

I also understand the need for this PR. Wouldn't accept.

momadthenomad commented 4 years ago

Why not reject/close the PR then?