florent37 / SingleDateAndTimePicker

You can now select a date and a time with only one widget !
Apache License 2.0
1.02k stars 333 forks source link

The title is focused/clicked when you click anywhere #275

Open momadthenomad opened 4 years ago

momadthenomad commented 4 years ago

Hello, we're having this strange issue where the title is getting focused/clicked, whenever you touch anywhere outside of the spinner.

I can only show the issue with a video.

https://www.dropbox.com/s/a8q5av5f9xyz60m/date-time-picker-strange-behavior.mp4?dl=0

I think the title should have focusable="false" and clickable="false", and the spinners should occupy 100% of the width so there are no gaps. That's how the iOS date picker works. I'll attempt a PR to fix this usability issue.

momadthenomad commented 4 years ago

Here's a picture illustrating where the click/drag boundaries should be. boundaries

And that box that appears where the title is should not appear. But in reality, the title gets highlighted if you click or try to drag the yellow sections below:

boundaries-2

And not just that, when you touch those sections, you can no longer scroll the individual spinners.

momadthenomad commented 4 years ago

Created Pull Request #276