florent37 / SingleDateAndTimePicker

You can now select a date and a time with only one widget !
Apache License 2.0
1.02k stars 333 forks source link

Revert "Removed unnecessary margins and use padding instead. Force th… #297

Closed arberg closed 3 years ago

arberg commented 3 years ago

I suggest reverting 2.2.5, hence this pull-request to make it easy for you if you accept.

2.2.5 does not produce a very nice result. Both the sample app and my production app looks much worse, when the picker view is full width. I want my production to have the divider line to the edges, like the sample app and like for instance Androids default settings app where lines are highlighted to phone edge. Therefore I cannot just add padding to the outer picker view.

If we are to support padding of the inner views, we could add inner view resource dimension for the padding, but I'm not convinced it is worth it. However Mannon (the author) could add such and leave the default production version of the picker unchanged, and all would be happy :)

florent37 commented 3 years ago

thanks I publish it