Fixed the issue about Feb. 31 or Apr. 31 (issue #166) - Githubissues

florent37 / SingleDateAndTimePicker

You can now select a date and a time with only one widget !

Apache License 2.0

1.02k stars 333 forks source link

Fixed the issue about Feb. 31 or Apr. 31 (issue #166) #312

Open chinalwb opened 3 years ago

chinalwb commented 3 years ago

What does this PR do?

This PR fixed the issue mentioned in #166 , we should never show Feb. 31 or Apr. 31.

How to test manually?

To reproduce:
1. Build the app with the code base
2. Run the sample app, taps on the first option: Click me to open single dialog
3. Scroll to select Jan. 31
4. Change the month picker to Feb.
5. Check the app
To verify:
1. Build the app with the branch chinalwb/SingleDateAndTimePicker
2. Do the same actions try to reproduce the issue
3. Check the app

Expected Behavior

[ ] The app should not show Feb. 31, that makes no sense
[ ] The app should show Feb. 28 or 29 (depends on the leap years)

chinalwb commented 3 years ago

Hi @florent37 , thanks for the great work!

Please take a look about this PR when you have some time, I hope it helps but not introduces new issues.

I am about to work out another PR for including this feature: https://github.com/florent37/SingleDateAndTimePicker/issues/161#issuecomment-525981698, please let me know what do you think about it.

Have a nice day guy! And Happy New Year, get a much better 2021!

Thanks!