florent37 / TutoShowcase

A simple and Elegant Showcase view for Android
Apache License 2.0
508 stars 89 forks source link

No centering round rect correctly #9

Closed emauro closed 6 years ago

emauro commented 8 years ago

I am trying to use TutoShowcase to show hint in a view that is a page of a ViewPager. For any view inside that view the roundrect is displayed displaced. See the image. problem

sathya541 commented 8 years ago

Any solutions? I'm facing the same issue

AlburIvan commented 8 years ago

I'm currently dealing with this too, mind to share what TutoShowcase configuration you're using for that tutorial specifically?. I want to see if I can fix this and send a pull request

AlburIvan commented 8 years ago

@emauro I can't seem to reproduce it again at work to see if I can fix this.

It is already fixed? or can someone supply the steps to reproduce this (maybe a simple example layout and code)

florent37 commented 8 years ago

can you send me an example of layout ? It seems that the height of the status bar is not added correctly

emauro commented 8 years ago

@florent37 That's the problem. Layout is pretty simple. The problem is that the layout is for a view that is inside a ViewPager, which is inside a Fragment.

darkholiday commented 8 years ago

hey, did you figure it out yet ?

AlburIvan commented 8 years ago

As @florent37 said, the problem is with the height of the status bar...
If I let the method addRoundRectOnView by default, the line with the statement below will add the incorrect height. final int y = rect.top - getStatusBarHeight() - padding;
Will make my layout look like this: screenshot_16

On the other hand if I remove the getStatusBarHeight() from the equation, it will correctly show the TutpShowCase view correctly (for this case... at least)
image

darkholiday commented 8 years ago

Thank you broh. Keep it up

hablema commented 8 years ago

This is happening for me with circle when i add it to a fab. How can i correct it?

4ybaka commented 6 years ago

Any solution? Still occurs.

florent37 commented 6 years ago

play with ".setFitSystemWindow(true / false)"