search

florentc / xob

A lightweight overlay volume (or anything) bar for the X Window System.
GNU General Public License v3.0
444 stars 13 forks source link

Allow Outline and Padding to have their own configurable colors #36

Closed Barbaross93 closed 3 years ago

Barbaross93 commented 3 years ago

This turned out to be a lot simpler than I expected. Let me know if I need to make any other adjustments, I was able to compile and run it fine. This closes https://github.com/florentc/xob/issues/35.

florentc commented 3 years ago

Thank you for the PR. I am merging it in a new feature branch for now because I plan to add a configurable separation line between the filled and unfilled part of the bar (such as in "proportional overflow mode") to be able to style xob like default bars such as in the mpv video player (fully transparent unfilled section with black outlines to make it visible on bright backgrounds). We also need to document these new features. Also there might be discussion as to how to name the fields and handle missing colors in the configuration file to avoid breaking people's config too much while still showcasing the feature.