florentianayuwono / pe

0 stars 0 forks source link

Unnecessary long command format for deletemeeting #10

Open florentianayuwono opened 1 year ago

florentianayuwono commented 1 year ago

image.png

Could be simplified to deletem, delete meet, deletemeet, etc.

Citing from the module web:

Unnecessarily complicated (or hard-to-type) command formats can be considered a type.FeatureFlaw as it is expected that the input formats will be optimized to get things done fast. Some examples: using very long keywords when shorter ones do, or making keywords case-sensitive when there is no need for it, using hard to type special characters in the format when it is possible to avoid them.

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unnecessary long and complicated command format for deletepersonfrommeeting

image.png

Can be: deletep meet 1 John Doe Jane Doe


[original: nus-cs2103-AY2223S1/pe-interim#5278] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As of milestone v1.4, the team was not able to make any changes to how commands were named.

https://github.com/AY2223S1-CS2103-F13-3/tp/issues/111 Similar issue found in PE-D

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: As stated in the module web:

image.png

Changing the command format for the original bug WILL NOT automatically change the command format for this bug, since they belong to different Command classes. Therefore this bug is not duplicate. The original command is for deletepersonfrommeeting, the second command is for deletemeeting.

Teaching team might want to consider this, as several duplicating attempts are also made by this team:

image.png


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: As the team mentioned, this issue has been raised even during PE-D. The team just choose not to care or do anything about it. Moreover, the decision on what kind of command format to implement is done since the very beginning. The team just decided to choose very unnecessary and complex command, without thinking from the user point of view, hence this is indeed a feature flaw. In addition, there is nowhere in their UG did they mention that they will change the command format in future iterations.