search

florentianayuwono / pe

0 stars 0 forks source link

Unnecessary long and complicated command format for deletepersonfrommeeting #13

Open florentianayuwono opened 1 year ago

florentianayuwono commented 1 year ago

image.png

Can be: deletep meet 1 John Doe Jane Doe

nus-pe-script commented 1 year ago

Team's Response

As of milestone v1.4, the team was not able to make any changes to how commands were named.

https://github.com/AY2223S1-CS2103-F13-3/tp/issues/111 Similar issue found in PE-D

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This is not a valid reasoning for notInScope. The team never mentioned that the command format will be changed in the UG. Furthermore, for the bug to be notInScope, the team should be able to justify why changing the command is hard and should be put later. Whereas in the reality, the team choose to implement such a complicated command format from the beginning. And choose to maintain the command format even after being mentioned by the issue found in PE-D, the team choose to do nothing. Looking at the team implementation:

image.png

image.png

image.png

Seems like it should be really easy to change the command, the team could just replace this with the simpler word.