florentianayuwono / pe

0 stars 0 forks source link

Various traces of AB3 naming is still present in the DG #22

Open florentianayuwono opened 1 year ago

florentianayuwono commented 1 year ago

The DG still refers to YellowPages as AddressBook.

image.png

and more. CTRL+F AddressBook should show all.

nus-se-script commented 1 year ago

Team's Response

Internally we still kept the name AddressBookParser within the application, hence it still reflects as correct.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Even though the team still keep the implementation as AddressBook*, it is still correct that various naming of AB3 that should be changed is not touched. For example, the team's new application is Yellow Pages, yet in their DG, it is found that the team still refer to the application name as Address Book:

image.png

image.png

Contrast this with how Yellow Pages and Address Book are both present in one page:

image.png

The fact that the team DG still contains these much of Address Book reference should clearly tell that the team indeed did not bother to make effort in changing the AB3 naming traces to suit their new application name.

image.png

It is not the job of tester to screenshot all of this instances and paste them during PE.