florian-h05 / webrtc-sip-gw

A WebRTC-SIP gateway for AVM Fritz!Box based on Kamailio and rtpengine.
MIT License
18 stars 7 forks source link

Any chance for a quick setup guide? :) #1

Closed stephanlinke87 closed 1 year ago

stephanlinke87 commented 1 year ago

Hi Nanosonde,

I'm somewhat struggling with the overhead of SIP Hass-Card (asterisk and co) with my doorbird intercom and I already had it working with my Fritzbox. Is there any chance you could post a quick howto on how to get this gateway working by any chance? :)

Thanks in advance, Stephan

nanosonde commented 1 year ago

Hi Stephan! Have a look at the forked version of this repo. @florian-h05

BTW: @florian-h05 Do you have any plans of opening a PR with your additions? I have also seen that you added a license file and claim to be the original author. I would be happy to accept a PR and also clarify the license situation.

stephanlinke87 commented 1 year ago

Awesome, thanks for the quick follow up on this! I'll try this right away :)

florian-h05 commented 1 year ago

@nanosonde

Do you have any plans of opening a PR with your additions?

Originally, I had this plan, but I wanted to add an ENV to let the user change the domainname of the SIP server, but I guess that’s not going to happen soon (I currently don’t have the time to develop the Docker Container).

I have also seen that you added a license file and claim to be the original author.

Yes, but I am wondering that I haven’t added any note to you being the original author. If you tell me your real name I can add you. I made larger changes, as the entrypoint did not work for me, upgraded the container to Debian 11 etc.

I would be happy to accept a PR and also clarify the license situation.

I can open a PR now, I just have to modify a few naming things to match your repo (I’d like to publish it to GitHub Docker Registry). Regarding the license situation: if you don’t have any preference, I’d keep MIT and state something like: Copyright 2022 your name & Florian Hotze.

nanosonde commented 1 year ago

I though about it again. Taking into account my available time, I think it would be best if you would take over the project. What do you think?

Also I should mention that I am also not the original author of the config files. I took the ideas from here: https://github.com/havfo/WEBRTC-to-SIP

So if you want to maintain this, I would either delete my repo or transfer ownership to you. So that other people will find your updated repo if they follow the old links, it would be best to transfer ownership.

Concerning my real name: I would prefer to stay in the dark. 😉

florian-h05 commented 1 year ago

No problem, then I‘ll use your GitHub username together with a short note FYI: The updated license will have the following copyright line:

Copyright (c) 2021 @nanosonde (https://github.com/nanosonde) & 2022 Florian Hotze
Configuration originally from Håvar Aambø Fosstveit at https://github.com/havfo/WEBRTC-to-SIP

Just use my mail address if it is ok for you: nanosonde@posteo.org

I will start the transfer now.

nanosonde commented 1 year ago

Mhmm, I get this if I start the transfer: grafik

nanosonde commented 1 year ago

Maybe I should just delete it.

If I remember correctly, I have only mentioned it on one forum. There are two other people who forked the project, but did not add anything. So maybe just a backup.

florian-h05 commented 1 year ago

I guess the problem is my fork. I‘ll open a PR upstream to your repo, please merge is using the Rebase and Merge option. Then I‘ll delete my fork and we can transfer the repo.

nanosonde commented 1 year ago

Ok, Rebased and merged.

I am ready to transfer the repo.

florian-h05 commented 1 year ago

@nanosonde I‘ve just deleted my fork, so you can try the transfer again.

florian-h05 commented 1 year ago

@nanosonde It worked, thanks 👍

nanosonde commented 1 year ago

Take care of yourself my little "webrtc-gw". I will always be there. 😉

florian-h05 commented 1 year ago

I‘ll take care of it. @nanosonde FYI: You are listed as a collaborator and you therefore should have elevated rights and push access.

nanosonde commented 1 year ago

Closing this.

nanosonde commented 1 year ago

BTW; redirect seems to work. Just checked it.