Proper imports in the node ecosystem (tldr; add .js everywhere)

florian-lefebvre / astro-integration-kit

A package that contains utilities to help you build Astro integrations.

https://astro-integration-kit.netlify.app

MIT License

54 stars 8 forks source link

Proper imports in the node ecosystem (tldr; add .js everywhere) #7

Open florian-lefebvre opened 7 months ago

florian-lefebvre commented 7 months ago

Reference: https://discord.com/channels/830184174198718474/1197638002764152843/1199038311319224420

natemoo-re commented 7 months ago

(Not so) hot take: every Astro integration should be published only as ESM. There's absolutely no reason to compile an integration to CJS.

florian-lefebvre commented 7 months ago

Sure we'll specify that! I was just referencing the .js discussion with Erika but ran out of ideas for this issue name xd

jdtjenkins commented 6 months ago

@florian-lefebvre can this close now then?

florian-lefebvre commented 6 months ago

Nope! I don't know if you saw the label but this is for guides! When we start writing documentation about how to write integrations start to finish, we'll need to talk about it.