Closed florian-lefebvre closed 3 months ago
Name | Link |
---|---|
Latest commit | 8294ef239b2e9d5dd6e1ea86e179e4d06d2cc485 |
Latest deploy log | https://app.netlify.com/sites/astro-integration-kit/deploys/660164da72c2f50008c9c134 |
Deploy Preview | https://deploy-preview-92--astro-integration-kit.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I am currently testing hasVitePluginPlugin
in the playground, and it looks like it is not working, but I am still investigating
The overriding issue can be fixed inside defineIntegration.ts
by spreading the params
after the plugins instead of before:
return providedHooks[hookName]?.({
- ...params,
...Object.fromEntries(
plugins.map((plugin) => [
plugin.name,
plugin.implementation(params, { name }),
]),
),
+ ...params,
} as any);
In this PR:
defineUtility
utilityhasVitePluginPlugin
have been removed as they do not bring anything compared to utilitiesUnfortunately, the PR got way too big so here is how you can review it without losing your sanity:
files
tab only review changes made outside ofdocs
I need confirmation on the
hasVitePluginPlugin
implementation. Does theupdateConfig
patching still work now that we passparams
directly?TODO:
defineUtility
hasVitePlugin