search

florian-lefebvre / astro-loading-indicator

Display a progress bar between page navigations when using View Transitions
MIT License
66 stars 6 forks source link

PSA: Updating to @swup/progress-plugin 3.2.0 breaks the indicator #5

Closed dallyh closed 5 months ago

dallyh commented 5 months ago

This is just a PSA for future. I had @swup/progress-plugin 3.2.0 installed in my project, and I decided to use this integration. However the progress bar was shown but never finished till the end.

So I cloned this repo, updated the plugin and observed the same behavior See here: https://github.com/dallyh/astro-loading-indicator.

Just install dependencies, and run the playground. Click the "about" link and observe that the indicator never finishes.

I currently did not dive deeper into this.

florian-lefebvre commented 5 months ago

Thanks for letting me know! I need to check their changelog (here's the diff https://github.com/swup/progress-plugin/compare/3.1.2...3.2.0)

florian-lefebvre commented 5 months ago

I just released 0.4.0 of the package, which removes the dependency entirely