search

florianfesti / boxes

Boxes.py - laser cutting boxes and more
GNU General Public License v3.0
957 stars 343 forks source link

LED Matrix #645

Closed fidoriel closed 1 month ago

fidoriel commented 3 months ago

This is a draft for a LED Matrix for those cheap Chinese ws2812b matrices. Like on my other PR, I need to wait for a chance to cut it.

florianfesti commented 3 months ago

You may want to not indent the content of the description string. It is formatted with markdown and indentation is treated as pre-formatted text.

Don't worry about the CI failure. This is not your fault and I'll look into how to fix that independently of your PR.

florianfesti commented 3 months ago

Wrt you still not having a laser cutter: I really feel you. I have to leave my laser cutter behind when moving several years ago and was without one for quite a while. Live without a laser cutter is possible but ultimately pointless.

fidoriel commented 3 months ago

I am new to the laser cutting game. Some things are more efficient, larger and look better if cutter. They promised they will have a cutter soon ;)

fidoriel commented 1 month ago

For some reason, not all images are shown

fidoriel commented 1 month ago

Everything is tested and fixes now. I am happy :)

fidoriel commented 1 month ago

@florianfesti did you find a solution to the typing error

Don't worry about the CI failure. This is not your fault and I'll look into how to fix that independently of your PR.

Did you find a solution or should I add a type ignore here?

florianfesti commented 1 month ago

OK, fixed CI failure. Added the thumbnail to the checksums file and squashed all the commits.

Thanks for your work! Enjoy your new laser cutter!