search

florianhartig / BayesianTools

General-Purpose MCMC and SMC Samplers and Tools for Bayesian Statistics
https://cran.r-project.org/web/packages/BayesianTools/index.html
119 stars 29 forks source link

Package dependencies in unit tests #136

Closed florianhartig closed 6 years ago

florianhartig commented 6 years ago

Dear maintainers,

This concerns the CRAN packages

AFM ASGS.foyer BayesianTools Cyclops DEploid DescribeDisplay EBMAforecast EValue EcoGenetics FSA FedData FuzzyAHP GBJ GGally Gmisc KFAS MetaComp NetLogoR PRROC ParamHelpers PeakSegOptimal PivotalR REddyProc RItools RNifti RStoolbox RcmdrPlugin.lfstat SensMap SpaDES SpaDES.core SpaDES.tools SuperLearner TOSTER aprof batchtools bayesboot biomartr bnclassify bomrang brms

maintained by one of you:

These seem to have undeclared package dependencies in their unit test code (R files in tests subdirs), see below.

Can you pls fix as necessary? (Add the missing package dependencies to Suggests, I guess.)

Please note that these issues are currently not yet detected by the CRAN incoming (or regular) checks.

Best -k

-- Issue

$BayesianTools 'library' or 'require' call not declared from: ‘Matching’

MaximilianPi commented 6 years ago

There shouldn't be an error, because Matching will be only used in manual tests:

test <- "CRAN" # avoids exact tests
# test <- "exact"

if(test == "exact"){
  iter = 500000
  start = 500
  iterSMC = 400
  library(msm) 
  library(Matching) # Because this is only needed for manual testing I removed it from
  # the package dependencies. If you are running the manual tests please install
  # the package yourself.

I set the library call also as comment: 637fc3423e5e8ce02a26a724d2643cc6194192eb