florianhartig / BayesianTools

General-Purpose MCMC and SMC Samplers and Tools for Bayesian Statistics
https://cran.r-project.org/web/packages/BayesianTools/index.html
115 stars 29 forks source link

Finalize 0.1.6 CRAN release #174

Closed florianhartig closed 5 years ago

florianhartig commented 5 years ago

Issue with winbuilder R dev, see https://win-builder.r-project.org/hQqsjLMzW2yt

this notification has been generated automatically.
Your package BayesianTools_0.1.6.tar.gz has been built (if working) and checked for Windows.
Please check the log files and (if working) the binary package at:
https://win-builder.r-project.org/hQqsjLMzW2yt
The files will be removed after roughly 72 hours.
Installation time in seconds: 56
Check time in seconds: 402
Status: 2 ERRORs
R Under development (unstable) (2019-01-18 r75994)

@JohannesOberpriller - looks like an issue with some syntax / casting behaviour in R dev? I'll have a look at it, but just for fun, have a look if you can see what's going wrong, and ask @MaximilianPi to explain the old / stable / dev system!

florianhartig commented 5 years ago

OK, the error seems to be in https://github.com/florianhartig/BayesianTools/blob/a3d2752370e9b287ccf323db07adca4e4bab54b8/BayesianTools/tests/testthat/test-createBayesianSetup.R#L63

The prior and thus bs1$prior$lower is a vector, so this evaluates to a vector and should thus be all (x & x)

Fun fact - the current R version nevertheless evaluates && without problems (short-curcuiting) - it seems they build a check / error in the new dev version?

This is the behavior of my local R

`

c(1,1) > 1 && c(1,1) > 1 [1] FALSE c(1,1) > 1 & c(1,1) > 1 [1] FALSE FALSE `

florianhartig commented 5 years ago

OK, seems that this is fixed ... I think I'll submit this to CRAN now.