Closed olivroy closed 8 months ago
Thanks! Just to know this - was there are problem with the old version, or are there any significant advantages of this one? In the latter case, we should push this to all packages.
@MaximilianPi maybe we should create a central workflow repo for our workflows?
No problem... yet! But I guess this is future proof, as the old actions likely won't be maintained at some point in the future. These use the pak package which can be used to automatically query any system requirement.
Indeed a good idea to update in packages, as part of the upkeep process!
If you use the default workflow, locally, using usethis::use_github_action("check-standard")
gets those. But I made some modifications to adapt to your setting the working directory and add a second check with args: 'c("--no-multiarch", "--no-manual")'
as was there before. Also, you test for windows devel, which I kept as well.
working-directory: BayesianTools
# second check with different rcmdcheck arguments.
- uses: r-lib/actions/check-r-package@v2
with:
upload-snapshots: true
working-directory: BayesianTools
args: 'c("--no-multiarch", "--no-manual")'
- uses: r-lib/actions/check-r-package@v2
with:
upload-snapshots: true
working-directory: BayesianTools
Thanks for the explanations! PR Looks good to me, I will merge this!
As this is the most recent workflow version from https://github.com/r-lib/actions/blob/v2/examples/check-standard.yaml
I added working-directory to setup-r-dependencies and check-package to account for the package code not being in the top level directory.