Open florianhartig opened 3 years ago
Hi Sean,
thanks for that. Two immediate comments / thoughts:
The latter is simply that (apart from the significant work do do so), experience shows that if you implement a an innocent additional feature at some point in a larger software project, you are carrying this around for years, and it often restricts what you can do later. For that reason, I would add additional interface features only if they are strictly necessary, and I don't see why this is the case here, because the users could simply run the functions on the single DHARMa objects.
For the same reason (I'm sorry, I realize that you put quite a bit of work in this), I wonder about the necessity to overload simulateResiduals. Why can't the user simply create a range of DHARMa objects, as in
m1 = lm()
r1 = simulateResiduals(m1)
plot(r1)
m2 = lm()
r2 = simulateResiduals(m2)
plot(r2)
and then the only thing to do would be to add a summary function
summary(r1,r2)
that implements the desired summary statistics (and possibly some messages that give advice about particular problems)
Thanks, Florian. I agree with your arguments that updating simulateResiduals is not necessary and will overcomplicate things. I'll focus my efforts instead on a summary function as you described it. Also, don't worry, I just added a for loop to simulateResiduals so I haven't sunk a lot of time into this (yet) ;)
OK, great!
Hi Sean, I wanted do ask - are you still actively working on this?
Hi Florian,
I apologize for not being responsive about this. I'm not actively working on this, but I should be able to pick it up again in the next couple of months. That said, I understand if you would like to implement this on your own schedule.
Sean
On Tue, Jan 26, 2021 at 8:48 AM Florian Hartig notifications@github.com wrote:
Hi Sean, I wanted do ask - are you still actively working on this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/florianhartig/DHARMa/issues/204#issuecomment-767634111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHSPB4YDUSURP3DQ4A55HI3S33P3XANCNFSM4RQJVTEA .
Hi Sean,
no worries, I am just scheduling a new release and wanted to know if we should include it in there, just moved this issue to future development for the moment.
Cheers, Florian
Great! thank you.
From @seanhardison1