[Intro to iOS] Week 1 - Review my app

[florianjourda]

Please review /cc @codepathreview

[dirkdk]

awesome app!

• tab bar should be for Box- DVD, segmented control for List - Icon view
• search is a bit wonky, there is no way to get out of search (keyboard remains visible)

[florianjourda]

Thanks for reviewing it!

• Yes, I started using tab bar for Box-DVD and segmented control for List-Icon view, but it was taking too much real-estate, so I went with a UI more like Secret with a segmented control at the top. Is it ok to take liberties like this?
• Yes, adding searchBar was easy to UITableView but hard/hacky for UICollectionView. I tried to reuse the same searchBar for both of them. It was pretty hard to get to work. There are still some glitches in the UICollectionView.

[dirkdk]

ah, as we are in a class, next time I'd keep it simple and follow the instructions. One thing you could have done is combining the search and segmented control in one bar, to limit screen usage.

[florianjourda]

Sounds good!

[codepathreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

• Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
• Nice work with the header files. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file). In future homework, we will cover how to implement models that can deserialize from an NSDictionary. It might be interesting to check out the Mantle project for a lightweight ORM.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Nice work loading the images asynchronously.
• Nice work setting up the proper modes for the images so that they are not stretched.
• Nice work implementing the error message on network failure.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

--dirk