search

florianmari / LiveGQL

Use GraphQL Subscriptions on iOS :ok_hand:
MIT License
83 stars 11 forks source link

Add Carthage support #2

Closed josefdolezal closed 7 years ago

josefdolezal commented 7 years ago

Hey @florianmari! As mentioned in #1, I added support Carthage dependency manager.

From now on, whenever Podspec is changed, it should be reflected in library .xcodeproj (if it's necessary). Also, Carthage doesn't use any spec file, so versions should be managed with git tags and should use semantic versioning.

We may consider setting up Danger to check for these things automatically when PR is created.

florianmari commented 7 years ago

Hello, thank you so much for you PR, I'm gonna add some unit tests, build tests and so on asap!

josefdolezal commented 7 years ago

Cool, let me know if you need a hand!