search

florianschanda / miss_hit

MATLAB Independent, Small & Safe, High Integrity Tools - code formatter and more
GNU General Public License v3.0
158 stars 21 forks source link

Automatic fixing ignores justifications #288

Open pvogt09 opened 3 months ago

pvogt09 commented 3 months ago

MISS_HIT Component affected Please choose one from:

Your MATLAB/Octave environment

Your operating system and Python version

Describe the bug Running the style checker with the autofix option and default configuration on

% symblic derivation
xdot % mh:ignore_style
y % mh:ignore_style
dzdx = jacobian(xdot, x) % mh:ignore_style
dzdu = jacobian(xdot, u) % mh:ignore_style
dzdmv = jacobian(xdot, u(1)) % mh:ignore_style
dydx = jacobian(y, x) % mh:ignore_style

fixes this file to

% symblic derivation
xdot; % mh:ignore_style
y; % mh:ignore_style
dzdx = jacobian(xdot, x); % mh:ignore_style
dzdu = jacobian(xdot, u); % mh:ignore_style
dzdmv = jacobian(xdot, u(1)); % mh:ignore_style
dydx = jacobian(y, x); % mh:ignore_style

by adding a semicolon to every line that was supposed to be ignored. The style checker without autofix option does not complain about the missing semicola though.

florianschanda commented 2 weeks ago

I have to admit, I did not consider this use-case.