search

floriansemm / SolrBundle

Solr-Integration into Symfony and Doctrine2
http://floriansemm.github.io/SolrBundle
MIT License
123 stars 73 forks source link

Add DSN and schema configuration options #159

Closed patrikorup closed 7 years ago

patrikorup commented 7 years ago

This PR contains 2 new configuration options, dsn and schema.

The code for parsing the DSN has been taken from the NelmioSolariumBundle, but has been placed in SolariumClientBuilder class, since I were unable to use env() parameters when placed in the Configuration class (as in NelmioSolariumBundle). Maybe related to https://github.com/symfony/symfony/issues/21420

floriansemm commented 7 years ago

Can you write some tests for the set/unset magic in https://github.com/floriansemm/SolrBundle/pull/159/files#diff-cb63448229e563c2322de27f407b951dR56

floriansemm commented 7 years ago

thanks!