florianutz / Ubuntu1804-CIS

Ubuntu CIS Hardening Ansible Role
MIT License
212 stars 127 forks source link

Missing "when" statement for section 1.8 - OS patching #42

Closed MartyFox closed 5 years ago

MartyFox commented 5 years ago

Hi,

There appears to be a missing when statement in section "1.8 | PATCH | Ensure updates, patches, and additional security software are installed" It is desirable option to be able to disable this as most organisations will want to regaulte the updates to their systems:

Before

- name: "NOTSCORED | 1.8 | PATCH | Ensure updates, patches, and additional security software are installed"
  apt:
      upgrade: dist
  tags:
      - level1
      - notscored
      - patch
      - rule_1.8
      - skip_ansible_lint

After

- name: "NOTSCORED | 1.8 | PATCH | Ensure updates, patches, and additional security software are installed"
  apt:
      upgrade: dist
  when:
      - ubuntu1804cis_rule_1_8
  tags:
      - level1
      - notscored
      - patch
      - rule_1.8
      - skip_ansible_lint
MartyFox commented 5 years ago

closing as similar issue opened, will add this content to that issue.