Docblocks - Githubissues

florianv / business

:date: DateTime calculations in business hours

http://florianv.github.io/business

MIT License

361 stars 25 forks source link

Closed sagikazarmark closed 9 years ago

sagikazarmark commented 9 years ago

I noticed a few minor things related to docblocks:

Integers are represented as integer instead of int (which is good IMO), but booleans are bool.
There are no @throws docblocks

florianv commented 9 years ago

Integers are represented as integer instead of int (which is good IMO), but booleans are bool

It's an issue indeed, it should be int instead of integer to match HHVM and PHP7 type names

There are no @throws docblocks

They need to be added (will do it once I have time)