search

florianv / business

:date: DateTime calculations in business hours
http://florianv.github.io/business
MIT License
361 stars 25 forks source link

Holidays::addHolidays is private #15

Closed bendavies closed 9 years ago

bendavies commented 9 years ago

Hi Florian!

Thanks for a great library! Can I ask why Holidays::addHolidays is private? I have a use case where i want to dynamically add holidays after the Business object has been instantiated, so I'm having resort to trickery to access Holidays::addHolidays at the moment.

Would you consider making that method public?

Thanks!

florianv commented 9 years ago

Hey Ben,

thanks for your feedback!

I don't see any issue making these methods public.

bendavies commented 9 years ago

Thanks, I'll submit a PR when i get some time.

florianv commented 9 years ago

Ok thank you!

I think we can put Holidays::addHoliday public as well.