florianv / business

:date: DateTime calculations in business hours
http://florianv.github.io/business
MIT License
361 stars 25 forks source link

Added support for \JsonSerialize interface. #20

Closed dragosprotung closed 8 years ago

dragosprotung commented 8 years ago

There is a workaround I had to do in the DateRange class due to a bug in HHVM. See https://github.com/facebook/hhvm/issues/3947 for more details.

florianv commented 8 years ago

Hello @dragosprotung, thanks for your PR!

I'm quite busy this week but I will try to review it soon.

dragosprotung commented 8 years ago

Thanks for letting me know. I'll wait for your review.

florianv commented 8 years ago

Looks good to me :+1:

florianv commented 8 years ago

Looks good to me after the last small thing :+1:

florianv commented 8 years ago

Thanks for you PR @dragosprotung !