Open euri10 opened 2 years ago
@euri10 Oops, just seeing this now. This looks pretty cool. Instead of "Others", should we initiate a "Debugging" section?
Am I right saying this middleware isn't framework-agnostic "pure ASGI", due to the request.app
access here? But it will work with any Starlette-based framework?
I think it could be made framework-agnostic by doing that request.app.debug
check safely (ignore if attributes aren't there) and accept a debug flag, e.g. via a parameter on the middleware.
@euri10 Oops, just seeing this now. This looks pretty cool. Instead of "Others", should we initiate a "Debugging" section?
I'm happy wwith either
Am I right saying this middleware isn't framework-agnostic "pure ASGI", due to the
request.app
access here? But it will work with any Starlette-based framework?
yep I commented in your issue there, this is starlette only, which is too bad: as a user of "many" frameworks it would be awesome to have at least a common base of asgi "extensions" / "plugins" that stay the same !!
Checklist
What is this project?
this is a exception handler / debugger middlware that displays amazing output in the developement phase
Do you know about other similar projects?
no
If so, how is this one different?
Anyone who agrees with this pull request can add a 👍.