florimondmanca / djangorestframework-api-key

🔐 API key permissions for Django REST Framework
https://florimondmanca.github.io/djangorestframework-api-key/
MIT License
669 stars 103 forks source link

Enhance APIKey ModelAdmin Class #203

Closed mustafaabughazy closed 2 months ago

mustafaabughazy commented 2 years ago

Enhance APIKey ModelAdmin Class

codecov-commenter commented 2 years ago

Codecov Report

Merging #203 (e313772) into master (57d0bc0) will increase coverage by 0.58%. The diff coverage is 98.55%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   97.11%   97.70%   +0.58%     
==========================================
  Files          22       22              
  Lines         520      653     +133     
==========================================
+ Hits          505      638     +133     
  Misses         15       15              
Impacted Files Coverage Δ
src/rest_framework_api_key/admin.py 90.32% <94.87%> (+13.39%) :arrow_up:
tests/test_admin.py 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

florimondmanca commented 2 years ago

Thanks again @Mustafa-Abu-Ghazy for opening this. As in #204, I need to ask for us to write up what problem these changes help address. If possible, let's do this in an issue explaining what practical problems or limitations currently exist with the default ModelAdmin.

mustafaabughazy commented 2 years ago

Hi @florimondmanca,

It's not a problem as much it's enhancement for the user experience while dealing with the APIKeyModelAdmin

Both of revoke and verify actions add a log into the LogEntry table and will be shown in the instance change history.