Ensured Django 4 support

florimondmanca / djangorestframework-api-key

🔐 API key permissions for Django REST Framework

https://florimondmanca.github.io/djangorestframework-api-key/

MIT License

678 stars 104 forks source link

Ensured Django 4 support #205

Closed florimondmanca closed 1 year ago

florimondmanca commented 2 years ago

Currently, we're testing against Django 3.2 max.

But Django 4.0 was released in December 2021: https://www.djangoproject.com/weblog/2021/dec/07/django-40-released/ and 4.1 is just around the corner (alpha state).

Let's ensure this library has continued support for this newer Django major series.

KyleBehielsCertn commented 1 year ago

@florimondmanca Was wondering if there was any progress on this or plans to support Django 4.2.x now that it's in LTS. TIA

florimondmanca commented 1 year ago

Hi @KyleBehielsCertn

This ticket is up for grabs for anyone who’d like to help advance it.

Lemme jot down what I think needs to be done to close this off…

Add a step to CI to test under the latest Django 4.2.x
- If there are changes required to CI templates, please ping me or take a look at https://github.com/florimondmanca/azure-pipelines-templates
Take note of any broken tests and fix those
Add a trove classifier for Django 4 un setup.py, so it shows in the README badge

That should do the trick. Then we can package this change into a new version.

florimondmanca commented 1 year ago

@KyleBehielsCertn Thanks to @fgrassals we merged #235 which revealed no changes were required for 4.2.x support. There should be a release soon, but this means the package should work out of the box even in the current version. Unless you'd report otherwise! Thanks.