Optional TemperatureClient to redirect temperature readings another HA entity

floringhimie / salusfy

SALUS THERMOSTAT Custom component for Home-Assistant

37 stars 16 forks source link

Optional TemperatureClient to redirect temperature readings another HA entity #22

Closed matthewturner closed 5 months ago

matthewturner commented 8 months ago

Fixes #17, #19

I've been working on a fork for a while. I'm not sure if any of the changes are of interest but there may be some useful bits.

Separated out components into discreet classes
Added an optional TemperatureClient and Client wrapper to redirect temperature readings to another entity via the Home Assistant API
Switched all calls to async
Fixed various deprecation warnings
Added run.py script for testing locally
Added simulator classes
Added unit tests
Added devcontainers for running unit tests in VS Code
Added Github CI

romicaiarca commented 8 months ago

I have installed your component and On run I have the following log message:

climate:
  - platform: salusfy
    username: "email"
    password: "password"
    id: "salusDeviceId"
    enable_temperature_client: False

And it looks like the integration is looking for access_token and entity_id. They should be set as optional and they should be required only if enable_temperature_client: True

To make the integration work, I had to add this into my config:

climate:
  - platform: salusfy
    access_token: "your-HA-access-token"
    entity_id: "your-entity"
    username: "email"
    password: "password"
    id: "salusDeviceId"
    enable_temperature_client: False

matthewturner commented 8 months ago

Ah thanks, I hadn't tested without those values. I've made them optional now.

What was the log message you got?

romicaiarca commented 8 months ago

Ah thanks, I hadn't tested without those values. I've made them optional now.

What was the log message you got?

Logger: homeassistant.config
Source: config.py:1293
First occurred: 10:50:55 AM (2 occurrences)
Last logged: 10:50:55 AM

Invalid config for 'climate' from integration 'salusfy' at custom_configs/salufy.yaml, line 2: required key 'access_token' not provided, please check the docs at https://github.com/floringhimie/salusfy Invalid config for 'climate' from integration 'salusfy' at custom_configs/salufy.yaml, line 2: required key 'entity_id' not provided, please check the docs at https://github.com/floringhimie/salusfy

I will try to fork and make a HACS compatible component from your fork with am instalation UI, in order to make the component more flexible and no pass passwords through config files.

matthewturner commented 8 months ago

I've just removed the extra settings from configuration.yaml and confirmed it now works correctly.