Closed zediogoviana closed 1 year ago
@florinpatrascu when you have the time, could you have a look at this?
Hi and I apologize that I don't have time to respond at length to the PRs. First of all I want to thank you for this improvement. Then about the PR. Don't you think it would be better if we keep one parameter: ssl
, converted to a list (of options). A list of options, can be the equivalent to ssl: true
?! What do you think?
Thanks for the reply, and for your time on this project! Yes, I agree with you! It seems to be a cleaner solution. I'll update the PR 👍
@florinpatrascu what do you think now? It should keep working if someone just passes true
, for retro-compatibility and also for the ones that don't want to specify any custom option.
Thank you! ❤️
Why:
How:
:ssl
(by specifyingtrue
to keep retro-compatibility or by specifying a keyword list).:ssl
the default list is used.