florinpatrascu / bolt_sips

Neo4j driver for Elixir
Apache License 2.0
256 stars 49 forks source link

Add configurable SSL options #108

Closed zediogoviana closed 1 year ago

zediogoviana commented 1 year ago

Why:

How:

zediogoviana commented 1 year ago

@florinpatrascu when you have the time, could you have a look at this?

florinpatrascu commented 1 year ago

Hi and I apologize that I don't have time to respond at length to the PRs. First of all I want to thank you for this improvement. Then about the PR. Don't you think it would be better if we keep one parameter: ssl, converted to a list (of options). A list of options, can be the equivalent to ssl: true?! What do you think?

zediogoviana commented 1 year ago

Thanks for the reply, and for your time on this project! Yes, I agree with you! It seems to be a cleaner solution. I'll update the PR 👍

zediogoviana commented 1 year ago

@florinpatrascu what do you think now? It should keep working if someone just passes true, for retro-compatibility and also for the ones that don't want to specify any custom option.

florinpatrascu commented 1 year ago

Thank you! ❤️