Bring up `:boltex` and `:retry` in `applications` - Githubissues

florinpatrascu / bolt_sips

Neo4j driver for Elixir

Apache License 2.0

258 stars 49 forks source link

Bring up `:boltex` and `:retry` in `applications` #18

Closed wli0503 closed 7 years ago

wli0503 commented 7 years ago

I've noticed that boltex and retry are listed as dependencies but their apps are not started properly. For users using elixir under 1.4.0, the applications won't start themselves automatically causing failures in productions environment. This patch explicitly start those apps.

Let me know how you think about this one. Thanks for your time and looking forward to hear from you!

florinpatrascu commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/florinpatrascu/bolt_sips/pulls/18.

florinpatrascu commented 7 years ago

thank you @wli0503. I'll push a new version containing this PR. However, please keep in mind that the driver requires Elixir 1.4.x starting w/ v2.

florinpatrascu commented 7 years ago

published https://hex.pm/packages/bolt_sips/0.2.2, thank you!

wli0503 commented 7 years ago

Hi @florinpatrascu Thank you so much for the rapid response! Glad to see it's pushed and ready to go!

florinpatrascu commented 7 years ago

No problem, thank you for your support!

florinpatrascu commented 7 years ago

Hey @wli0503 - quick question. You did mention production deployments, and that stirred my curiosity :) Are you using Bolt.Sips in production?

wli0503 commented 7 years ago

@florinpatrascu Sorry about the late reply. I can't say much about it but we're experimenting it since bolt is much better than the http interface for neo4j in terms of both performance and stability.

florinpatrascu commented 7 years ago

No worries, I understand. Thank you anyway :)