add the fuzzyurl to the list of apps

florinpatrascu / bolt_sips

Neo4j driver for Elixir

Apache License 2.0

256 stars 49 forks source link

add the fuzzyurl to the list of apps #21

Closed dnesteryuk closed 7 years ago

dnesteryuk commented 7 years ago

The fuzzyurl must be placed there, otherwise, when the url config option is in use, the following error appears in a compiled project:

(UndefinedFunctionError) function Fuzzyurl.from_string/1 is undefined (module Fuzzyurl is not available)

There is another option to fix the issue. A project using the bolt_sips has to add the fuzzyurl to its applications list. It works, but I think it is a wrong approach, the dependencies of the bolt_sips might be changed later.

florinpatrascu commented 7 years ago

Hello, @dnesteryuk! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

florinpatrascu commented 7 years ago

Ebert has finished reviewing this Pull Request and has found:

1 possible new issue (including those that may have been commented here).
1 fixed issue! 🎉

You can see more details about this review at https://ebertapp.io/github/florinpatrascu/bolt_sips/pulls/21.

florinpatrascu commented 7 years ago

thank you for th PR. This is required only for the projects running Elixir < 1.4, correct? Did you try bolt_sips with Elixir 1.4?

florinpatrascu commented 7 years ago

Package published to https://hex.pm/packages/bolt_sips/0.2.4, thanks again! 🍻

dnesteryuk commented 7 years ago

Thank you, Florin! Actually, I got this error after compiling a project with Elixir 1.4. It might not happen to projects compiled with Elixir 1.3.