Integrate boltex - Githubissues

dominique-vassard commented 5 years ago

Hi, This is the first step: boltex integration. Everything can be found in the internals directory.

3 notes / questions:

the logger didn't come at the root, because it's dedicated to the internals (message, etc.). Is it ok for you?
Regarding errors, I think that we can rely only on Bolt.Sips one and remove the internal ones, I don't think that the level of details provided is interesting (or in log maybe)
I don't understand well how travis matices work, but it seems that it's not possible to have include and the benfits of the env at the same time, hence the not-so-pretty list of neo4j/elixir/otp versions

sourcelevel-bot[bot] commented 5 years ago

Hello, @dominique-vassard! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

florinpatrascu commented 5 years ago

Spent a bit of time yesterday going over the changes and this is awesome, thank you!!!

florinpatrascu commented 5 years ago

@dominique-vassard - the new package is published, sorry for the delay; bolt_sips/1.1.0-rc2

dominique-vassard commented 5 years ago

It wasn't that long though. Thanks.

Next step: temporal and spatial types!

florinpatrascu / bolt_sips

Integrate boltex #53