search

florinpatrascu / bolt_sips

Neo4j driver for Elixir
Apache License 2.0
256 stars 49 forks source link

Set proper INT_8 range #94

Closed kalamarski-marcin closed 3 years ago

kalamarski-marcin commented 3 years ago

According to https://boltprotocol.org/v1/#ints

sourcelevel-bot[bot] commented 3 years ago

Hello, @kalamarski-marcin! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

sourcelevel-bot[bot] commented 3 years ago

SourceLevel has finished reviewing this Pull Request and has found:

See more details about this review.

florinpatrascu commented 3 years ago

Thank you! Don't remember why we had -127 there :/ @dominique-vassard care to validate this PR please? If everything else is fine we'll push a new release tomorrow morning. Thanks again!

dominique-vassard commented 3 years ago

It's ok for me. '-128' was indeed lacking. Thanks for spotting and fixing the bug!